fix: exit error code on arg parse failure (#112)

denoland · Mar 21, 2024 · e8f8954 · e8f8954
1 parent 7d0e506
commit e8f8954
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/shell/commands/exit.rs b/src/shell/commands/exit.rs
@@ -21,9 +21,8 @@ impl ShellCommand for ExitCommand {
     let result = match execute_exit(context.args) {
       Ok(code) => ExecuteResult::Exit(code, Vec::new()),
       Err(err) => {
-        // even if parsing args fails `exit` always exits
         context.stderr.write_line(&format!("exit: {err}")).unwrap();
-        ExecuteResult::Exit(1, Vec::new())
+        ExecuteResult::Exit(2, Vec::new())
       }
     };
     Box::pin(futures::future::ready(result))

diff --git a/src/shell/test.rs b/src/shell/test.rs
@@ -191,6 +191,13 @@ async fn exit() {
     .assert_exit_code(1)
     .run()
     .await;
+
+  TestBuilder::new()
+    .command("exit bad args")
+    .assert_stderr("exit: too many arguments\n")
+    .assert_exit_code(2)
+    .run()
+    .await;
 }
 
 #[tokio::test]