feat: support parsing fd redirects #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 29, 2024
| TestBuilder::new() | ||
| .command(r#"cat - <&0"#) | ||
| .assert_stderr( | ||
| "deno_task_shell: redirecting file descriptors is not implemented\n", |
There was a problem hiding this comment.
We at least have a nicer error message now.
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Mar 21, 2024
* feat: implement exit status var (denoland/deno_task_shell#110) * feat: support input redirects (denoland/deno_task_shell#106) * feat: support output fd redirects for stdout and stderr (denoland/deno_task_shell#111) * feat: support parsing fd redirects (denoland/deno_task_shell#107) * fix: exit error code on arg parse failure (denoland/deno_task_shell#112) Closes #22989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #106This implements fd redirects in the parser (because I want it for Dax). We can do the shell implementation later.