Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow jsr packages to be mapped #398

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

maraisr
Copy link
Contributor

@maraisr maraisr commented Mar 30, 2024

When wanting to map jsr packages to npm it would be nice to not crash.

example

await build({
  // ...
  mappings: {
    'jsr:@mr/object-identity': {
      name: 'object-identity',
      version: '^1'
    }
  } 
});
$ deno task build
error: Uncaught (in promise) "The following specifiers were indicated to be mapped to a package, but were not found:\n  * file:///Users/stuff/jsr:@mr/object-identity"

I am not 100% sure this will fix the issue, but sounds promising 🙏🏻

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2024

CLA assistant check
All committers have signed the CLA.

@dsherret dsherret changed the title Allow jsr packages to be mapped fix: allow jsr packages to be mapped May 28, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret merged commit 00b9ab7 into denoland:main May 28, 2024
1 check passed
@maraisr maraisr deleted the mr/adds-jsr branch May 28, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants