move api reference navigation to sidebar #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this as a visual update. It feels like it adopts and stenghtens the conventions about showing hierarchy around the docs site It also lends itself well to having an intro explanatory page for each section which is present in the sidebar nav too. |
|
This feels SO much cleaner and more logical. Q: Should the sidebar highlight the active section for All [Deno|Node|Web] Symbols as it does with other sections and in prod? (It doesn't currently, and feels like it should if possible. (See https://deno-docs-4f1c2gr361t7.deno.dev/api/deno/all_symbols) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API reference sidebar feels ugly and clunky, I've moved it over to the left hand sidebar and grouped the three "sections" under one menu
I have also moved each of the 'api landing pages' that are currently in runtime/reference/ into the api reference section, so, for example
https://docs.deno.com/runtime/reference/deno_namespace_apis/ becomes https://docs.deno.com/api/deno/
I've also made the accordions collapse when a different accordion is expanded and now the sidebar will scroll to the correct position when a page is loaded to show the 'active' link in the browser viewport.
Old:
New:
