Limit the concurrency of link checker #952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently link checker causes
Reached heap limit
error in CI. This PR tries to fix it.Currently the link checker checks all
<a>
tags concurrently (and it also does that recursively if it finds a new page). This PR limits the concurrency to 10 and tries to prevent the memory error.(This PR also removes the
.hash
property from URL before visiting. This removes the duplicated checks of URLs which only differ in hash part.)