Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making a link checker that hopefully wont crash the build #956

Merged
merged 11 commits into from
Oct 7, 2024

Conversation

thisisjofrank
Copy link
Collaborator

No description provided.

@thisisjofrank thisisjofrank requested review from magurotuna and kt3k and removed request for magurotuna October 7, 2024 14:30
return href.startsWith("/") ? new URL(href, this.rootUrl) : new URL(href);
});

this.displayAnyEmptyLinkErrors(emptyLinks, pageUrl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice check 👍

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice detailed reports and DIY queueing 👍 LGTM

@thisisjofrank thisisjofrank merged commit 9ba8df1 into main Oct 7, 2024
4 checks passed
@thisisjofrank thisisjofrank deleted the better-link-checker branch October 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants