This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
Fix TOC for /manual and /style_guide #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - But now there are two markdown parsers..? |
ry
reviewed
Oct 24, 2019
ry
reviewed
Oct 24, 2019
src/Markdown.js
Outdated
| } | ||
|
|
||
| // Using logic from markdown-toc | ||
| const slugify = text => { |
There was a problem hiding this comment.
Please follow the Deno style guide ("Top level functions should not use arrow syntax
") and use function slugify(text) { here
ry
reviewed
Oct 24, 2019
ry
reviewed
Oct 24, 2019
|
|
lucacasonato
added a commit
to lucacasonato/dotland
that referenced
this pull request
May 13, 2020
* Update readme * Fix link
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used markdown-toc to generate the table of contents for both the markdown files.
I have also added a custom heading renderer since
react-markdowndoesn't add anchor tags to headings by default. See hereCloses #24