Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: refactor docs/[...slug].tsx to make use of optional dynamic params #1750

Open
mbhrznr opened this issue Sep 7, 2023 · 9 comments · May be fixed by #2770
Open

www: refactor docs/[...slug].tsx to make use of optional dynamic params #1750

mbhrznr opened this issue Sep 7, 2023 · 9 comments · May be fixed by #2770
Labels
docs good first issue Good for newcomers

Comments

@mbhrznr
Copy link
Contributor

mbhrznr commented Sep 7, 2023

depends on #1706.

once merged, it would be nice to refactor www's docs/[...slug].tsx to make use of the new concept.

@yossydev
Copy link

yossydev commented Dec 4, 2023

@marvinhagemeister
Hello! Is this issue still existing?
If you don't mind, I would like to work on this problem myself!

@marvinhagemeister
Copy link
Collaborator

yes, this is still open. Feel free to go ahead.

@yossydev
Copy link

yossydev commented Dec 7, 2023

Thank you!! I will tackle it!!

@Mrashes
Copy link
Contributor

Mrashes commented Jul 3, 2024

@yossydev Are you still working on this? I can take a look if not

@yossydev
Copy link

yossydev commented Jul 4, 2024

@Mrashes
Sorry, I haven't got around to it at the moment, please do!

@Mrashes
Copy link
Contributor

Mrashes commented Jul 5, 2024

Alright, started digging for an hour. Few things to start calling out:

  • can't get the optional routing to work out of the box (idea is docs/[[version]]/[...slug]). It results in too many redirects when I try to hit docs/introduction
  • Its a bit tricky due to the middleware so I'm going to try and ignore that for now
  • Docs are a bit out of date so I'll update those

Next step is to just get it working where when I hit docs/latest/introduction it should render locally. Probably just need more head banging but wanted to update on progress. Hope is to do this an hour at a time for the next few nights.

@bhb603
Copy link
Contributor

bhb603 commented Nov 22, 2024

Activity seems stale here, so going to take a stab at this 😄

@Mrashes
Copy link
Contributor

Mrashes commented Nov 22, 2024

@bhb603 gfi!

@bhb603
Copy link
Contributor

bhb603 commented Dec 4, 2024

PR ready 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants