-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for optional dynamic route params #1706
feat: add support for optional dynamic route params #1706
Conversation
would add some documentation once we've settled on the general approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! Going with the way Svelte does it makes a lot of sense. Like this much more then the original proposed [...id]
. Found one additional case to account for, but other than that it looks really good and I'm excited to have this in Fresh 👍
would it make sense to refactor |
Let's tackle that in another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is great!
tackles #1690.
this pr is a first attempt to support optional dynamic routes.
the file name convention is inspired by sveltekit's established convention.
the feature can be tested in the primary fixture by running:
once started, navigate to
/i18n/lang
and/i18n/:lang/lang
.