Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fresh islands are broken with preact 1.22.1 #2587

Closed
JOTSR opened this issue Jul 9, 2024 · 1 comment
Closed

bug: fresh islands are broken with preact 1.22.1 #2587

JOTSR opened this issue Jul 9, 2024 · 1 comment

Comments

@JOTSR
Copy link

JOTSR commented Jul 9, 2024

Fresh island rendering is broken in preact 1.22.1

Bug

children.js:123 Uncaught (in promise) TypeError: n2.contains is not a function
    at S (children.js:123:16)
    at O (index.js:246:4)
    at S (children.js:85:3)
    at O (index.js:246:4)
    at B (render.js:37:2)
    at _render (main.ts:109:7)

image

It seems that fresh root fragments of islands are missing contains method.

Bug reason

The PR replace isConnected with parentDom.contains #4421 breaks fresh island rendering with new contains method.

@marvinhagemeister
Copy link
Collaborator

Resolved in #2596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants