Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #465

Closed
wants to merge 2 commits into from
Closed

Conversation

synalice
Copy link
Contributor

@synalice synalice commented Jul 7, 2022

It's not the best one, but might be a good place to start.

Copy link
Contributor

@fdemir fdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@un-versed
Copy link
Contributor

Nice! I was missing this...

What about commit messages? Should we have a pattern?

Personally I like to use https://www.conventionalcommits.org/en/v1.0.0/

@synalice
Copy link
Contributor Author

synalice commented Jul 7, 2022

@un-versed, absolutely agree. They are very nice and already seem to be the standard for the repository.

Although I'm not sure if it's necessary to add this into CONTRIBUTING.md since all PRs when merged get squashed into single properly named commit.

@lucacasonato, what do you think?

@iuioiua
Copy link
Contributor

iuioiua commented Jun 1, 2023

Closing this as Deno repos mainly refer to a central Contributing page. We're adding the link to that page in the README in #1233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants