Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combine the objects for synthetic import map #71

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 9, 2024

This suddenly came to my mind while I was sleeping last night lol. We need to combine the import map objects instead of overriding.

Closes #70

@dsherret dsherret requested a review from mmastrac February 9, 2024 17:44
Copy link

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 28f6b7c into denoland:main Feb 9, 2024
4 checks passed
@dsherret dsherret deleted the fix_combine_import_maps_better branch February 9, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine scopes rather than overwrite in synthetic import map
2 participants