Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure that shim-deno runs (not necessarily correctly) on Node 14 #82

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

wojpawlik
Copy link
Contributor

Closes #77. Closes #15.

The step I replaced could never fail.

npm publish step seems unused.

Since there isn't a pre-commit hook anymore, https://github.com/denoland/node_deno_shims/blob/aa22b201add21509bea5effe7fd59128b4ade32b/packages/shim-deno/tools/missing.ts#L36-L42 slows down tools/missing.ts for no benefit.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 6cc15d7 into denoland:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Node LTS
2 participants