Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value returned by "value_deserializer" cannot outlive the "value_deserializer" #607

Closed
inteon opened this issue Feb 9, 2021 · 1 comment · Fixed by #609
Closed

Value returned by "value_deserializer" cannot outlive the "value_deserializer" #607

inteon opened this issue Feb 9, 2021 · 1 comment · Fixed by #609

Comments

@inteon
Copy link
Contributor

inteon commented Feb 9, 2021

The returned value from "value_deserializer.read_value(...)" should be able to outlive value_deserializer.
Current lifeline configuration does not allow this.
Is needed for this denoland/deno#9323 prototype.
This was referenced Feb 9, 2021
Merged
Merged
bnoordhuis added a commit to bnoordhuis/rusty_v8 that referenced this issue Feb 9, 2021
@bnoordhuis
Fix ValueDeserializer::read_value() lifetime
ae8dc8f 
The return value should have the lifetime of the context, not the
deserializer.

Fixes denoland#607.
@bnoordhuis bnoordhuis mentioned this issue Feb 9, 2021
Merged
@bnoordhuis
Copy link
Contributor

Thanks for the bug report. Fix in #609.

bnoordhuis added a commit that referenced this issue Feb 10, 2021
@bnoordhuis
Fix ValueDeserializer::read_value() lifetime (#609)
5dc6117 
The return value should have the lifetime of the context, not the
deserializer.

Fixes #607.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ValueDeserializer::read_value() lifetime bnoordhuis/rusty_v8
2 participants
@bnoordhuis @inteon