Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo: improve test coverage #267

Closed
Tracked by #60
iuioiua opened this issue Jun 19, 2023 · 7 comments
Closed
Tracked by #60

todo: improve test coverage #267

iuioiua opened this issue Jun 19, 2023 · 7 comments
Assignees
@mbhrznr
Labels
good first issue Good for newcomers v1

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Jun 19, 2023 •
edited
Loading

The aim is to have code coverage at 100%.
@iuioiua iuioiua added the good first issue Good for newcomers label Jun 19, 2023
This was referenced Jun 19, 2023
Closed
Closed
Open
@mbhrznr
Copy link
Contributor

mbhrznr commented Jun 20, 2023

would love to tackle this!

@mbhrznr mbhrznr mentioned this issue Jun 20, 2023
Merged
This was referenced Jun 22, 2023
Merged
Merged
Merged
@iuioiua
Copy link
Contributor Author

iuioiua commented Jun 23, 2023

For those wanting to help, I'd welcome a PR that takes care of test coverage for Vote within utils/db.ts.

@mbhrznr
Copy link
Contributor

mbhrznr commented Jun 23, 2023

since i already familiarized myself w/ utils i'd tackle that one as well.

@niklasmtj niklasmtj mentioned this issue Jun 25, 2023
Merged
@mbhrznr mbhrznr mentioned this issue Jun 26, 2023
Merged
@brunocorrea23 brunocorrea23 mentioned this issue Jun 28, 2023
Merged
@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 2, 2023 •
edited
Loading

We're now at almost 100%! Thank you to all that helped out with this.

@iuioiua iuioiua closed this as completed Jul 2, 2023
@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 4, 2023

Re-opening this as coverage has slipped a little as things have changed.

@iuioiua iuioiua reopened this Sep 4, 2023
@iuioiua iuioiua added the v1 label Sep 4, 2023
@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 4, 2023

I've expanded the coverage surface area in #495.

@iuioiua iuioiua changed the title todo: improve test coverage within utils folder todo: improve test coverage Sep 4, 2023
@iuioiua iuioiua mentioned this issue Sep 7, 2023
Merged
iuioiua added a commit that referenced this issue Sep 7, 2023
@iuioiua
refactor: polish posts tests and documentation (#531)
9c5590f 
Towards #267 and #492.
@iuioiua iuioiua mentioned this issue Sep 7, 2023
Merged
iuioiua added a commit that referenced this issue Sep 7, 2023
@iuioiua
refactor: complete utils/display.ts tests and docs (#532)
9eee4cc 
Towards #267 and #492.
@iuioiua iuioiua pinned this issue Sep 9, 2023
This was referenced Sep 9, 2023
Merged
Merged
Merged
iuioiua added a commit that referenced this issue Sep 9, 2023
@iuioiua
chore: add POST /api/stripe-webhooks catches and tests (#546)
5199c63 
Towards #267 and
#492
@iuioiua
Copy link
Contributor Author

iuioiua commented Oct 16, 2023

While not at 100%, test coverage is more than sufficient.

@iuioiua iuioiua closed this as completed Oct 16, 2023
@iuioiua iuioiua unpinned this issue Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbhrznr mbhrznr

Labels
good first issue Good for newcomers v1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbhrznr @iuioiua