Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: validate urls #378

Closed
boywithkeyboard opened this issue Jul 18, 2023 · 1 comment · Fixed by #443
Closed

proposal: validate urls #378

boywithkeyboard opened this issue Jul 18, 2023 · 1 comment · Fixed by #443
Labels
enhancement New feature or request v1

Comments

@boywithkeyboard
Copy link

I'd suggest to validate links, so you don't end up with something like this:

image
@boywithkeyboard boywithkeyboard added the enhancement New feature or request label Jul 18, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Jul 19, 2023

Yes, I think this would be a nice addition.

@iuioiua iuioiua added the v1 label Jul 19, 2023
@mbhrznr mbhrznr mentioned this issue Aug 22, 2023
Merged
iuioiua added a commit that referenced this issue Aug 22, 2023
@mbhrznr @iuioiua
feat: add URL validation (#443)
088c0ff 
closes #378.  

adds some naive url validations to the submit route.  
adds some tests for these naive validations.

these validations check that:
- the urls start w/ `http:` or `https:`
- the urls don't use local ip addresses and/or `localhost`

---------

Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add URL validation mbhrznr/saaskit
2 participants
@iuioiua @boywithkeyboard