Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: password reset flow #142

Merged
merged 6 commits into from
May 3, 2023
Merged

feat: password reset flow #142

merged 6 commits into from
May 3, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 1, 2023

Able to take a look, @thorwebdev?

Todo:

  • Documentation

Supersedes #105.

@thorwebdev
Copy link
Contributor

The code looks good to me, the only thing is, when I test it on my project, I don't receive the email, and I currently don't know why. Is it working for you?

@iuioiua
Copy link
Contributor Author

iuioiua commented May 3, 2023

Yeah, it worked the last time I tried. Let me try again.

@iuioiua
Copy link
Contributor Author

iuioiua commented May 3, 2023

I can't get it working on my local machine. I assume external emails aren't supported on a local Supabase instance. I can confirm it works on the preview deployment.

@iuioiua
Copy link
Contributor Author

iuioiua commented May 3, 2023

I'll go ahead and merge this PR as it's working in the preview deployment. We can explore the testing of the password reset flow in #157.

image

@iuioiua iuioiua merged commit 616ef53 into main May 3, 2023
@iuioiua iuioiua deleted the feat-password-reset-2 branch May 3, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants