Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: user display names #144

Merged
merged 11 commits into from
May 4, 2023
Merged

feat: user display names #144

merged 11 commits into from
May 4, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 2, 2023 •
edited
Loading

This will only work for new users. A database reset will likely be needed.

Closes #116.

@iuioiua iuioiua mentioned this pull request May 2, 2023
Merged
@iuioiua iuioiua requested a review from kt3k May 2, 2023 23:09
@iuioiua iuioiua marked this pull request as ready for review May 2, 2023 23:09
@iuioiua
Copy link
Contributor Author

iuioiua commented May 3, 2023

PTAL, @kt3k.

kt3k
kt3k approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit ed213cc into main May 4, 2023
@iuioiua iuioiua deleted the feat-display-names branch May 4, 2023 04:21
@iuioiua iuioiua mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: user display names
2 participants
@iuioiua @kt3k