Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove comments count #171

Merged
merged 4 commits into from
May 10, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 9, 2023

This change removes the comments part of <ItemSummary />. Previously, this was argued to be a good indicator of an interesting item. However, with the complexity and computational cost of such a minor feature and the onset of voting functionality, it's more reasonable not to have the feature. A vote score is a sufficient indicator of an item's value.

However, an item's comment count can still be seen on the item page, which is calculated without an extra database call through comments.length. A few other adjustments had to be made to make <ItemSummary /> usable:

  1. The item title now links to the item page.
  2. The item URL host now links to the item URL in a new tab, with a symbol included to indicate so.
  3. Both new links get underlined upon hovering to clarify their intent.

CC @huai-jie

@iuioiua iuioiua marked this pull request as ready for review May 9, 2023 05:58
@iuioiua iuioiua requested review from lambtron and kt3k and removed request for kt3k May 9, 2023 05:59
@huai-jie
Copy link
Contributor

huai-jie commented May 9, 2023

I'm good with it 👍

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 7f43889 into main May 10, 2023
@iuioiua iuioiua deleted the remove-comments-summary-in-item-summary branch May 10, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants