Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avatar Images on Profile Page #220

Merged
merged 6 commits into from
May 22, 2023

Conversation

zzeleznick
Copy link
Contributor

Description

This PR adds the current user's avatar image on the /account page.

Addresses #213

Adds

  • User avatar image

Removes

  • Unused reset password logic

Visual Diff

Before After
Screen Shot 2023-05-20 at 5 25 40 PM Screen Shot 2023-05-20 at 5 26 27 PM

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zzeleznick. I'm not too sold on the exact current design. I have two design ideas:

  1. Delete the "Account"
  2. Or make the avatar image as small as 2 lines and put it next to the username row.
    WDYT?

@zzeleznick
Copy link
Contributor Author

@iuioiua – I'm also not sold on the current user profile page design, but I opted with your first suggestion as I feel like option (2) where the profile image is in-line with the username is more of a mobile design (using Github's profile page as a reference)/

Github Profile Normal Mobile View
Screen Shot 2023-05-21 at 9 48 28 AM Screen Shot 2023-05-21 at 9 48 41 AM

I also added in the user's name but I can remove it if you'd prefer.

@iuioiua
Copy link
Contributor

iuioiua commented May 22, 2023

Let's omit the user's name for now. Removing the "Account" heading should suffice. I have considered adding the user's name as a property to User but decided not to include it as the login property is versatile enough.

@zzeleznick
Copy link
Contributor Author

@iuioiua – updated

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note: including the user display name at this point would've required a database reset. While we have to reset the database occasionally, I'm trying to keep it to a minimum.

Either way, my ugly avatar image is looking very nice. And nice cleanup with the reset password stuff. LGTM! Thank you.

routes/account/index.tsx Show resolved Hide resolved
@iuioiua iuioiua changed the title Avatar Images on Profile Page feat: Avatar Images on Profile Page May 22, 2023
@iuioiua iuioiua merged commit 74f2d18 into denoland:main May 22, 2023
@zzeleznick zzeleznick deleted the zz/profile-avatar branch May 22, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants