-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Avatar Images on Profile Page #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zzeleznick. I'm not too sold on the exact current design. I have two design ideas:
- Delete the "Account"
- Or make the avatar image as small as 2 lines and put it next to the username row.
WDYT?
@iuioiua – I'm also not sold on the current user profile page design, but I opted with your first suggestion as I feel like option (2) where the profile image is in-line with the username is more of a mobile design (using Github's profile page as a reference)/
I also added in the user's name but I can remove it if you'd prefer. |
Let's omit the user's name for now. Removing the "Account" heading should suffice. I have considered adding the user's name as a property to |
@iuioiua – updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note: including the user display name at this point would've required a database reset. While we have to reset the database occasionally, I'm trying to keep it to a minimum.
Either way, my ugly avatar image is looking very nice. And nice cleanup with the reset password stuff. LGTM! Thank you.
Description
This PR adds the current user's avatar image on the
/account
page.Addresses #213
Adds
Removes
Visual Diff