-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: page-number-based pagination on homepage #242
Conversation
Does this PR gonna tackle |
Not so much. We can do that in another PR. |
@iuioiua , thanks for the work here and for requesting the review. Couple of comments on the proposed solution.
Wdyt? |
Yes, as it stands now. Later, we can add functionality to make the window customisable.
True, the amount of loading is sub-optimal. This will be fixed if/when Does the PR look good to you? |
ok, thanks for the clarification! LGTM |
This PR:
Note: once merged, these same changes can be made to paginate item and user pages.
Please feel free to review, @brunocorrea23 and @huai-jie.