Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding new stats #244

Merged
merged 8 commits into from
Jun 4, 2023
Merged

feat: adding new stats #244

merged 8 commits into from
Jun 4, 2023

Conversation

brunocorrea23
Copy link
Contributor

@brunocorrea23 brunocorrea23 commented May 30, 2023

@iuioiua
Copy link
Contributor

iuioiua commented May 31, 2023

Are you able to increase the spacing between graphs? They appear a little squished up.

@iuioiua
Copy link
Contributor

iuioiua commented Jun 1, 2023

The new layout on desktop is great! Are you able to fix the layout on smaller screens?
localhost_8000_stats(iPhone SE)
localhost_8000_stats

@brunocorrea23
Copy link
Contributor Author

@iuioiua , I would appreciate some help here.
I noticed that the charts are not responsive, but I'm not sure how to fix this.
Can we tackle this on a next PR? I can create an issue. Also would like to add a tooltip, but also not sure how to do it.

@iuioiua
Copy link
Contributor

iuioiua commented Jun 2, 2023

Ok, I'll merge this when I can. Let's tackle the responsiveness issue after 👍🏾

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. After making a tweak, LGTM for now! Note: I do think that some of this logic is a little difficult to understand. We can address this in a follow-up PR, alongside increasing the polish of the entire codebase for v1.

@iuioiua iuioiua merged commit 4eabda6 into denoland:main Jun 4, 2023
@brunocorrea23 brunocorrea23 deleted the analytics branch June 5, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants