-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redirect to referrer page after login #249
Conversation
Interesting means of redirecting... I like it! You might be able to extract both code blocks into a single combined middleware function and apply this to the |
Hmm ... Currently , I handle the cases for
Then set the Finally, at I don't see if it needs to combine these 2 into a function
Still a bit confused about this. Would you mind providing more details or examples? |
Deno SaaSKit aims to be modular. Having the newly introduced functionality from this PR encapsulated in a single function would be ideal, perhaps using |
Okay, I believe it's worth a try to implement this improvement.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please merge @/utils/http.ts
into the new @/utils/redirect.ts
along with tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @huai-jie! Well done.
i.e
Clicking on the
comment
button on an item's page initiates thelogin
process. It would be beneficial if, after logging in, users could be redirected back to the same item page.