Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: charts not responsive #259

Merged
merged 4 commits into from
Jun 18, 2023
Merged

fix: charts not responsive #259

merged 4 commits into from
Jun 18, 2023

Conversation

huai-jie
Copy link
Contributor

close #251

Before
image

After
image

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead insert the new class in a <style> in the <Head /> for the stats page? We should also note somewhere that this is a workaround for Fresh Charts not being responsive. I've made a suggestion for that issue.

@huai-jie huai-jie marked this pull request as draft June 14, 2023 10:52
@iuioiua
Copy link
Contributor

iuioiua commented Jun 17, 2023

Sorry, @huai-jie. To clarify, I'm happy to merge this PR, as long as we note that it's a workaround and try using <style>.

@huai-jie
Copy link
Contributor Author

huai-jie commented Jun 17, 2023

Can we instead insert the new class in a <style> in the <Head /> for the stats page? We should also note somewhere that this is a workaround for Fresh Charts not being responsive. I've made a suggestion for that issue.

done it 👍

@huai-jie huai-jie marked this pull request as ready for review June 17, 2023 09:05
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @huai-jie!

@iuioiua iuioiua merged commit 156d295 into denoland:main Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

todo: make charts responsive / mobile friendly
2 participants