test(http): basic endpoint tests

.github/codecov.yml

@@ -6,4 +6,8 @@ coverage:
         informational: true
     patch:
       default:
-        informational: true
+        informational: true
+ignore:
+  - "components"
+  - "islands"
+  - "routes"

tests/http_test.ts

@@ -0,0 +1,161 @@
+// Copyright 2023 the Deno authors. All rights reserved. MIT license.
+
+import { createHandler } from "$fresh/server.ts";
+import manifest from "@/fresh.gen.ts";
+import {
+  assert,
+  assertEquals,
+  assertFalse,
+  assertInstanceOf,
+  assertStringIncludes,
+} from "std/testing/asserts.ts";
+import type { ConnInfo } from "std/http/server.ts";
+
+const CONN_INFO: ConnInfo = {
+  localAddr: { hostname: "localhost", port: 8000, transport: "tcp" },
+  remoteAddr: { hostname: "localhost", port: 53496, transport: "tcp" },
+};
+
+Deno.test("[http]", async (test) => {
+  const handler = await createHandler(manifest);
+
+  await test.step("[get] /", async () => {
+    const response = await handler(new Request("http://localhost"), CONN_INFO);
+
+    assert(response.ok);
+    assertInstanceOf(response.body, ReadableStream);
+    assertEquals(
+      response.headers.get("content-type"),
+      "text/html; charset=utf-8",
+    );
+    assertEquals(response.status, 200);
+  });
+
+  await test.step("[get] /account", async () => {
+    const response = await handler(
+      new Request("http://localhost/account"),
+      CONN_INFO,
+    );
+
+    assertFalse(response.ok);
+    assertFalse(response.body);
+    assertEquals(
+      response.headers.get("location"),
+      "/signin?from=http://localhost/account",
+    );
+    assertEquals(response.status, 303);
+  });
+
+  await test.step("[get] /callback", async () => {
+    const response = await handler(
+      new Request("http://localhost/callback"),
+      CONN_INFO,
+    );
+
+    assertFalse(response.ok);
+    assertInstanceOf(response.body, ReadableStream);
+    assertEquals(
+      response.headers.get("content-type"),
+      "text/html; charset=utf-8",
+    );
+    assertEquals(response.status, 500);
+  });
+
+  await test.step("[get] /blog", async () => {
+    const response = await handler(
+      new Request("http://localhost/blog"),
+      CONN_INFO,
+    );
+
+    assert(response.ok);
+    assertInstanceOf(response.body, ReadableStream);
+    assertEquals(
+      response.headers.get("content-type"),
+      "text/html; charset=utf-8",
+    );
+    assertEquals(response.status, 200);
+  });
+
+  await test.step("[get] /pricing", async () => {
+    const response = await handler(
+      new Request("http://localhost/pricing"),
+      CONN_INFO,
+    );
+
+    assertFalse(response.ok);
+    assertInstanceOf(response.body, ReadableStream);
+    assertEquals(
+      response.headers.get("content-type"),
+      "text/html; charset=utf-8",
+    );
+    assertEquals(response.status, 404);
+  });
+
+  await test.step("[get] /signin", async () => {
+    const response = await handler(
+      new Request("http://localhost/signin"),
+      CONN_INFO,
+    );
+
+    assertFalse(response.ok);
+    assertFalse(response.body);
+    assertStringIncludes(
+      response.headers.get("location")!,
+      "https://github.com/login/oauth/authorize",
+    );
+    assertEquals(response.status, 302);
+  });
+
+  await test.step("[get] /signout", async () => {
+    const response = await handler(
+      new Request("http://localhost/signout"),
+      CONN_INFO,
+    );
+
+    assertFalse(response.ok);
+    assertFalse(response.body);
+    assertEquals(response.headers.get("location"), "/");
+    assertEquals(response.status, 302);
+  });
+
+  await test.step("[get] /stats", async () => {
+    const response = await handler(
+      new Request("http://localhost/stats"),
+      CONN_INFO,
+    );
+
+    assert(response.ok);
+    assertInstanceOf(response.body, ReadableStream);
+    assertEquals(
+      response.headers.get("content-type"),
+      "text/html; charset=utf-8",
+    );
+    assertEquals(response.status, 200);
+  });
+
+  await test.step("[get] /submit", async () => {
+    const response = await handler(
+      new Request("http://localhost/submit"),
+      CONN_INFO,
+    );
+
+    assertFalse(response.ok);
+    assertFalse(response.body);
+    assertEquals(
+      response.headers.get("location"),
+      "/signin?from=http://localhost/submit",
+    );
+    assertEquals(response.status, 303);
+  });
+
+  await test.step("[post] /submit", async () => {
+    const response = await handler(
+      new Request("http://localhost/submit", { method: "POST" }),
+      CONN_INFO,
+    );
+
+    assertFalse(response.ok);
+    assertFalse(response.body);
+    assertEquals(response.status, 401);
+  });
+});

utils/db.ts

@@ -268,13 +268,6 @@ export async function createVote(vote: Vote) {
 export async function deleteVote(vote: Vote) {
   vote.item.score--;
 
-  const itemKey = ["items", vote.item.id];
-  const itemsByTimeKey = [
-    "items_by_time",
-    vote.item.createdAt.getTime(),
-    vote.item.id,
-  ];
-  const itemsByUserKey = ["items_by_user", vote.item.userId, vote.item.id];
   const votedItemsByUserKey = [
     "voted_items_by_user",
     vote.user.id,
@@ -286,11 +279,29 @@ export async function deleteVote(vote: Vote) {
     vote.user.id,
   ];
 
+  const [votedItemsByUserRes, votedUsersByItemRes] = await kv.getMany([
+    votedItemsByUserKey,
+    votedUsersByItemKey,
+  ]);
+
+  if (!votedItemsByUserRes.value || !votedUsersByItemRes.value) {
+    throw new Error(`Failed to delete vote: ${vote}`);
+  }
+
+  const itemKey = ["items", vote.item.id];
+  const itemsByTimeKey = [
+    "items_by_time",
+    vote.item.createdAt.getTime(),
+    vote.item.id,
+  ];
+  const itemsByUserKey = ["items_by_user", vote.item.userId, vote.item.id];
+
   const [itemRes, itemsByTimeRes, itemsByUserRes] = await kv.getMany([
     itemKey,
     itemsByTimeKey,
     itemsByUserKey,
   ]);
+
   const res = await kv.atomic()
     .check(itemRes)
     .check(itemsByTimeRes)