Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use TabsBar style at TimeSelector #406

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix: use TabsBar style at TimeSelector #406

merged 1 commit into from
Aug 2, 2023

Conversation

hashrock
Copy link
Contributor

@hashrock hashrock commented Aug 2, 2023

I like TabsBar style that we're using on the dashboard, so I replaced with it.
It looks different from Header Nav, and I think the selection state is easy to see. wdyt?

Before:
image

After:
image

image

@hashrock hashrock requested a review from iuioiua August 2, 2023 00:34
iuioiua
iuioiua approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! I was going to do this myself once I had the chance. Thank you.

@iuioiua iuioiua merged commit 7c8763c into main Aug 2, 2023
@iuioiua iuioiua deleted the tabsbar-style-time-selector branch August 2, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hashrock @iuioiua