feat: <ItemsList /> with cursor-based pagination
#445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Aug 25, 2023
iuioiua
changed the title
<ItemsList /><ItemsList /> with cursor-based pagination
Closed
kt3k
reviewed
Aug 29, 2023
Comment on lines
+38
to
+41
| const itemsSig = useSignal<Item[]>([]); | ||
| const votedItemsIdsSig = useSignal<string[]>([]); | ||
| const cursorSig = useSignal(""); | ||
| const isLoadingSig = useSignal(false); |
There was a problem hiding this comment.
I'm curious why useSignal is used here instead of useState
There was a problem hiding this comment.
Good question! For context: https://preactjs.com/blog/introducing-signals/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains a few changes that affect interdependent features. Changes include:
<ItemsList />with cursor-based paginationvaluesfieldfetchValues()<VoteButton />DELETE/GET /api/items/[id]/voteendpointGET /api/me/votesendpointNote: The migration script has been tested successfully locally.
Closes #427
Closes #414
Towards #439