perf: <StaticVoteButton />
#517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
suggested changes
Sep 6, 2023
|
|
||
| export interface ItemSummaryProps { | ||
| item: Item; | ||
| isVoted: boolean; | ||
| isSignedIn: boolean; |
There was a problem hiding this comment.
Nice! I wonder if having isVoted?: boolean might be simpler, where it's undefined if the user is not signed in. WDYT?
There was a problem hiding this comment.
Yeah, I like that suggestion if reusing the isVoted prop. What do you think about isVoted: boolean | undefined instead since we probably want that prop to be required?
There was a problem hiding this comment.
isVoted?: boolean is the same as isVoted: boolean | undefined (reference). Having isVoted?: boolean would mean it is optional. Btw, if, for whatever reason, it's not simpler, let's stick to using isSignedIn: boolean.
iuioiua
changed the title
<StaticVoteButton />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a component called
StaticVoteButton. Struggled on the same but I'm open to suggestions to make it more clear if needed. Thetitleattribute seemed to work well on hover (see attached screenshot).Related to #513