-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add e2e tests for GET /items/:id
, GET /account
, GET /dashboard
, GET /dashboard/stats
and GET /dashboard/users
#557
Conversation
GET /items/[id]
GET /items/[id]
and GET /account
}); | ||
}); | ||
|
||
Deno.test("[e2e] GET /account", async (test) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added missing tests for /account
but then moved all of the other /account/*
tests down to be alongside this one.
Ah I see, codecov ignores all @iuioiua what do you think about updating |
headers: { cookie: "site-session=" + user.sessionId }, | ||
}), | ||
); | ||
assertStringIncludes(await resp.text(), "<!--frsh-chart_default"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page itself renders an outlet for the island, and this assert is looking for the first piece of that outlet.
headers: { cookie: "site-session=" + user.sessionId }, | ||
}), | ||
); | ||
assertStringIncludes(await resp.text(), "<!--frsh-userstable_default"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page itself renders an outlet for the island, and this assert is looking for the first piece of that outlet.
GET /items/[id]
and GET /account
GET /items/[id]
,GET /account
, GET /dashboard
, GET /dashboard/stats
and GET /dashboard/users
GET /items/[id]
,GET /account
, GET /dashboard
, GET /dashboard/stats
and GET /dashboard/users
GET /items/[id]
, GET /account
, GET /dashboard
, GET /dashboard/stats
and GET /dashboard/users
Alrighty.. definitely feel free to take this PR and run with it in terms of syntax adjustments or changes here and there. I've got to get back into my regular obligations. It's been a bunch of fun! I'll try to circle back around to this repo and add contributions as I find more time. |
GET /items/[id]
, GET /account
, GET /dashboard
, GET /dashboard/stats
and GET /dashboard/users
GET /items/:id
, GET /account
, GET /dashboard
, GET /dashboard/stats
and GET /dashboard/users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add these in, but these will be analysed in Codecov after v1. I'd like to focus on REST API endpoints as they involve more logic. Either way, this is great! Thank you, Josh.
Adding more coverage on behalf of #524