-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Fresh 1.6.1 and std 0.208.0 #646
Conversation
@iuioiua, this is ready to go now. Although you might consider some style tests somewhere. I almost botched this by forgetting to add the |
Pretty much LGTM! I'll give this a spin tomorrow before approving. As for the styles test, let's create an issue to fix after we land this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I've updated to Fresh 1.6.1. But I've noticed a couple of visual issues:
- The top menu bar is no longer visible
- The social icons in the bottom-right corner are squashed together.
haven't checked for the issues iuioiua mentioned. Thus dismissing my review.
Thanks guys. I'll try again on Friday, first ensuring a near pixel perfect match. I guess I need to familiarize myself with the app's functionality 😅 |
Some progress here, but it's a slog. I had to hack it by leveraging the On the positive side, I'm obviously deep in the code checking out all the pages. So maybe I'll finally have something else to say in this repo after (if!?) I fix this 🙃 If either of you have any great ideas, I'm ready to be saved. Otherwise I'll continue later. |
Hm... I think Tailwind can't recognise classes if stored in variables. The fix may be as simple as removing these "class variables", like |
Still fighting with active links, but it's overall much better now. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work, @deer! Thanks for this.
"Someone" broke the hamburger menu in #646. This fixes the issue and cleans things up by making the CSS a bit more direct: * I use https://tailwindcss.com/docs/hover-focus-and-other-states#styling-based-on-sibling-state to modify the `nav` directly. * I add IDs to the hamburger and X components, and then use https://tailwindcss.com/docs/hover-focus-and-other-states#using-arbitrary-variants to directly target them, in combination with peer. FYI @hashrock since this restores the great work you did in #374.
closes #644
I see the guidelines have changed since I last contributed (thanks github!) and that caused me to look for an issue. Fortunately there was the above, but I see you want tailwind as well. I'll open this as a draft for now.