Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice for Deno not following semver #10

Closed
wants to merge 2 commits into from
Closed

Conversation

sno2
Copy link

@sno2 sno2 commented Jul 13, 2021

As shown by denoland/deno#11340, highly impactive breaking changes will be introduced within minor versions of Deno. It is best to warn people of this and have them specify their minor versions as well to stop all CI breaking again the next time a big breaking change like this is introduced again.

@sno2 sno2 changed the title Add notice for not following semver Add notice for Deno not following semver Jul 13, 2021
@lucacasonato
Copy link
Member

Our stability guarantees in general only cover runtime APIs (stable Deno namespace APIs, web APIs, type stripping), not auxiliary things like type checking or specific lint rules. Please see https://deno.land/manual@v1.12.0/runtime/stability

@sno2
Copy link
Author

sno2 commented Jul 13, 2021

Our stability guarantees in general only cover runtime APIs (stable Deno namespace APIs, web APIs, type stripping), not auxiliary things like type checking or specific lint rules. Please see https://deno.land/manual@v1.12.0/runtime/stability

Yes, I am talking about the CLI. It will no longer type check by default if you do not add a CLI flag. If that can be included within a minor version bump then everyone must specify their minor versions.

@lucacasonato
Copy link
Member

It is not yet decided that this will be included in a minor version, or what a possible migration path would look like.

@sno2
Copy link
Author

sno2 commented Jul 13, 2021

It is not yet decided that this will be included in a minor version, or what a possible migration path would look like.

It is tagged for the 1.13 milestone and locked for discussion. I advise you say something in the issue as there has not been a single statement from core team that it will not be 1.13. Kitsonk did discuss it not being <2.0 in the original discussion a year ago but I don't think he still has the same opinion if he hasn't changed the milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants