fix(http/file_server): keep url and name consistent (#908)

Add trailing slash to href on directories to match the name displayed on screen.
denoland · May 10, 2021 · b850d01 · b850d01
1 parent 69183a0
commit b850d01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/http/file_server.ts b/http/file_server.ts
@@ -179,7 +179,7 @@ async function serveDir(
       mode: modeToString(entry.isDirectory, fileInfo.mode),
       size: entry.isFile ? fileLenToString(fileInfo.size ?? 0) : "",
       name: `${entry.name}${entry.isDirectory ? "/" : ""}`,
-      url: fileUrl,
+      url: `${fileUrl}${entry.isDirectory ? "/" : ""}`,
     });
   }
   listEntry.sort((a, b) =>

diff --git a/http/file_server_test.ts b/http/file_server_test.ts
@@ -202,6 +202,7 @@ Deno.test("serveDirectory", async function () {
     assert(res.headers.has("access-control-allow-headers"));
     const page = await res.text();
     assert(page.includes("README.md"));
+    assert(page.includes(`<a href="/testdata/">testdata/</a>`));
 
     // `Deno.FileInfo` is not completely compatible with Windows yet
     // TODO(bartlomieju): `mode` should work correctly in the future.