ProtocolError: malformed MIME header initial line

[reggi]

I'm sending over a POST request and I think it's confusing the body for the header.

ProtocolError: malformed MIME header initial line: "query": "{ hello }",

[kevinkassimo]

Could you post the raw response that triggers this error?

[reggi]

{
  "query": "{ hello }",
  "operationName": "",
  "variables": {}
}

[kevinkassimo]

Sorry, but can you also include the headers and request line along with the request body (and especially any whitespace or CRLF characters between them)? I want to investigate where actually did the readMIMEHeader() fail...

[kevinkassimo]

Actually, have you sent the request correctly? Because it seems as if it is treating "query": "{ hello }", as the initial header line, which should only happen when it reads the first body line { as the first request line (which should be GET / HTTP/1.1 or something similar)... (looks as if no request line nor headers are sent along with the body...)

[reggi]

Here's the full request:

POST 8000
Content-Type: application/json
cache-control: no-cache
Postman-Token: c32b827f-bcfc-4c78-ac19-b98b6998bc61
User-Agent: PostmanRuntime/7.4.0
Accept: */*
Host: localhost:8000
accept-encoding: gzip, deflate
content-length: 68
{ "query": "{ hello }", "operationName": "", "variables": "" }
HTTP/1.1 200
status: 200
content-length: 47
{ "data": { "hello": "Hello world!" } }

Here's the full error:

ProtocolError: malformed MIME header initial line:   "query": "{ hello }",
    at ProtocolError (file:///Users/thomas.reggi/.deno/deps/https/deno.land/x/net/textproto.ts:20:5)
    at readMIMEHeader (file:///Users/thomas.reggi/.deno/deps/https/deno.land/x/net/textproto.ts:68:13)

Seems to be responding correctly but still failing.

[bartlomieju]

I managed to reproduce this issue, and it turns out this problem arises if you try to respond to request without reading its body.

http_bench.ts

import * as deno from "deno";
import { serve } from "./http.ts";

const addr = deno.args[1] || "127.0.0.1:4500";
const server = serve(addr);

const body = new TextEncoder().encode("Hello World");

async function main(): Promise<void> {
  for await (const request of server) {
    await request.body() // adding this line prevent ProtocolError
    await request.respond({ status: 200, body });
  }
}

main();

I guess a check is needed in request.respond that ensures whole requests has been read.

[bartlomieju]

I believe this was resolved in #49, can we close this now?