Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import https://github.com/lucascaro/deno-uuid into deno_std #403

Closed
ry opened this issue May 14, 2019 · 7 comments · Fixed by #479
Closed

import https://github.com/lucascaro/deno-uuid into deno_std #403

ry opened this issue May 14, 2019 · 7 comments · Fixed by #479

Comments

@ry
Copy link
Member

ry commented May 14, 2019

cc @lucascaro

@ry ry changed the title import https://github.com/lucascaro/deno-uuid import https://github.com/lucascaro/deno-uuid into deno_std May 14, 2019
@axetroy
Copy link
Contributor

axetroy commented May 14, 2019

Will it be better to port https://github.com/kelektiv/node-uuid ?

It contains several versions of UUID and is stable.

@hayd
Copy link
Contributor

hayd commented May 14, 2019

Looks like the deno one based on this gist? https://gist.github.com/jed/982883#gistcomment-2661313

@lucascaro
Copy link
Contributor

mine is pretty basic and it only supports v4, porting https://github.com/kelektiv/node-uuid would be a better option long term

@lucascaro
Copy link
Contributor

on the flip side, porting https://github.com/kelektiv/node-uuid would require more work since there's a fair amount of re-writing needed.

@lucascaro
Copy link
Contributor

Looks like the deno one based on this gist? https://gist.github.com/jed/982883#gistcomment-2661313

yep

@zekth
Copy link
Contributor

zekth commented May 18, 2019

denoland/deno#2327 would be revelant to use in deno-uuid no?

@lucascaro
Copy link
Contributor

taking a stab at this right now, I'll do an initial import of my code but using an api inspired in node-uuid, so we can iterate on it.

@ry ry closed this as completed in #479 Jul 3, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants