fix(hash): Fix broken handling of non-byte-sized TypedArray views #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, hash.update() corrupts input data if it comes from a TypedArray with items larger than a byte. The main source of trouble is:
If the input is an ArrayBuffer or a Uint8Array, this is correct. However, if it's an Int16Array, this will cause each 16-bit value to be cast to an 8-bit value, and those values will be hashed, as you could see in an example like:
Instead, it seems like the intended behaviour should be to hash the underlying bytes that the Int16Array is a view over, instead of a lossy coercion.
This commit updates our implementation to do that, and adds several test cases to make sure that various views of the same data produce the same result. It also avoids creating unnecessary copies of input data when we can instead just use another view of the same data (we consume the input synchronously, so we don't need to worry about it being changed under us).
Co-authored-by: @evanwashere evan@tsu.sh