fix(testing/_diff) Don't merge diff when a token that is surrounded by word-diffs isn't a space #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #948 by @lowlighter's great contribution, strings diff of assertion is now very readable.
But I found some edge case that strings diff displays like unwelcome.
It's a feature of merging word diffs if a in-between token is a space. Actually word diffs are merged even when the in-between token is not a space.
For example, this is as expected. Fine.
However, this is not as expected.
And this is also not as expected.
That's the issue. So this PR fixes it not to merge if the in-between token is not a space.
After fixed, above 2 bad examples will be improved as below.