refactor: make acceptWebSocket independent from ServerRequest #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good to me but CI is red. |
Contributor
Author
|
@ry I found that test files that call |
Member
|
@keroxp Yikes - not good. |
ry
reviewed
Feb 8, 2019
http/server_test.ts
Outdated
|
|
||
| import { Buffer } from "deno"; | ||
| import { test, assert, assertEqual } from "../testing/mod.ts"; | ||
| import { test, assert, assertEqual, runTests } from "../testing/mod.ts"; |
MaxGraey
reviewed
Feb 8, 2019
| const end = encoder.encode("\r\n"); | ||
| await writer.write(start); | ||
| await writer.write(chunk); | ||
| await writer.write(end); |
Contributor
There was a problem hiding this comment.
What about using copyBytes with one write?
await writer.write(
copyBytes(
copyBytes(
copyBytes(start, chunk), end
),
endChunk
)
);also end and endChunk could be concatenated before encode
Or this parts should be always flushed separately?
Member
There was a problem hiding this comment.
No need to flush separately. copyBytes will allocate new buffers which would be wasteful.
Member
ry
pushed a commit
to ry/deno
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acceptWebSocket,acceptableindependent fromServerRequestServerRequestmore statelessacceptable