Skip to content

test(crypto): test ReadableStream in digest #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kt3k merged 4 commits into from
Oct 18, 2022
Merged

test(crypto): test ReadableStream in digest #2766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6796ad
feat(crypto): support ReadableStreams in digest
iuioiua Oct 10, 2022
ac8e060
Merge branch 'denoland:main' into crypto-streams
iuioiua Oct 13, 2022
a0b93eb
remove: ReadableStream as input type for digest
iuioiua Oct 17, 2022
abbce8d
Merge branch 'denoland:main' into crypto-streams
iuioiua Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crypto/mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ const stdCrypto: StdCrypto = ((x) => x)({
subtle: {
...webCrypto.subtle,

/**
* Polyfills stream support until the Web Crypto API does so:
* @see {@link https://github.com/wintercg/proposal-webcrypto-streams}
*/
async digest(
algorithm: DigestAlgorithm,
data: BufferSource | AsyncIterable<BufferSource> | Iterable<BufferSource>,
Expand Down
27 changes: 27 additions & 0 deletions crypto/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,21 @@ Deno.test(
expectedDigest,
);

assertEquals(
toHexString(
await stdCrypto.subtle.digest(
"SHA-384",
new ReadableStream({
start(controller) {
controller.enqueue(inputBytes);
controller.close();
},
}),
),
),
expectedDigest,
);

assertEquals(
toHexString(
await stdCrypto.subtle.digest(
Expand Down Expand Up @@ -126,6 +141,18 @@ Deno.test("[crypto/digest] Should return an ArrayBuffer", async () => {
})(),
)) instanceof ArrayBuffer,
);

assert(
(await stdCrypto.subtle.digest(
"BLAKE3",
new ReadableStream({
start(controller) {
controller.enqueue(inputBytes);
controller.close();
},
}),
)) instanceof ArrayBuffer,
);
});

Deno.test("[crypto/digest] Should not ignore length option", async () => {
Expand Down