refactor(archive,async,cli,csv,dotenv,encoding,expect,fmt,front-matter,fs,http,internal,log,net,path,semver,testing,text,webgpu,yaml): enable "exactOptionalPropertyTypes" option

[petamoriken]

Related denoland/deno#25162

By including this PR, users will be able to use std modules without problems when the “exactOptionalPropertyTypes” option (which is recommended in tsconfig reference) is enabled.

[codecov]

Codecov Report

Attention: Patch coverage is 70.75812% with 81 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (890958c) to head (1e19c5d).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
http/file_server.ts	23.52%	13 Missing ⚠️
fs/walk.ts	50.00%	12 Missing ⚠️
testing/_test_suite.ts	76.47%	12 Missing ⚠️
webgpu/texture_with_data.ts	31.25%	11 Missing ⚠️
fs/expand_glob.ts	50.00%	6 Missing ⚠️
http/_negotiation/media_type.ts	14.28%	6 Missing ⚠️
log/setup.ts	0.00%	4 Missing ⚠️
archive/untar.ts	40.00%	3 Missing ⚠️
csv/stringify_stream.ts	80.00%	2 Missing ⚠️
expect/_build_message.ts	0.00%	2 Missing ⚠️
... and 9 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5892      +/-   ##
==========================================
- Coverage   96.32%   96.23%   -0.10%     
==========================================
  Files         483      483              
  Lines       39063    39156      +93     
  Branches     5730     5772      +42     
==========================================
+ Hits        37629    37683      +54     
- Misses       1390     1429      +39     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iuioiua]

I'm for strictness. Though, seeing as tests have to be modified, this seems like a breaking change. WDYT, @kt3k?

[kt3k]

Suggested change

	assertEquals(format(-0.4, { locale: undefined } as object), "-0.4 B");
	assertEquals(format(0.4, { locale: undefined } as object), "0.4 B");
	assertEquals(format(1001, { locale: undefined } as object), "1 kB");
	assertEquals(format(10.1, { locale: undefined } as object), "10.1 B");
	assertEquals(format(1e30, { locale: undefined } as object), "1000000 YB");
	assertEquals(format(-0.4, {}), "-0.4 B");
	assertEquals(format(0.4, {}), "0.4 B");
	assertEquals(format(1001, {}), "1 kB");
	assertEquals(format(10.1, {}), "10.1 B");
	assertEquals(format(1e30, {}), "1000000 YB");

[petamoriken]

I've placed both { locale: undefined } and {} tests.

[kt3k]

Though, seeing as tests have to be modified, this seems like a breaking change.

It seems to me that the changes in test cases are all caused by enabling exactOptionalPropertyTypes because there is no changes in public interfaces.

[petamoriken]

Canary CI failed by denoland/deno#25369

error: TS2724 [ERROR]: 'Deno' has no exported member named 'ServeTlsOptions'. Did you mean 'ServeOptions'?
    | Deno.ServeTlsOptions
           ~~~~~~~~~~~~~~~
    at file:///home/runner/work/std/std/http/file_server.ts:860:12

TS2724 [ERROR]: 'Deno' has no exported member named 'ServeTlsOptions'. Did you mean 'ServeOptions'?
    | (Deno.ServeTlsOptions & Deno.TlsCertifiedKeyOptions) = {
            ~~~~~~~~~~~~~~~
    at file:///home/runner/work/std/std/http/file_server.ts:861:13

Found 2 errors.

[kt3k]

What does this mean?

[petamoriken]

I used Deno.ServeTlsOptions, but it was renamed to Deno.ServeTcpOptions in Deno v2 (denoland/deno#25369), so I wrote directly this flat type 😭

[kt3k]

LGTM