Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(expect): fix typo on objectContaining example #6357

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

rogerpoliver
Copy link
Contributor

Hi, I was reading the documentation for expect.objectContaining and noticed a mistake in the example.

The first expectation is incorrect because the expected value for the key bar does not match the actual value. I've updated the example to reflect the correct behavior.

@rogerpoliver rogerpoliver requested a review from kt3k as a code owner January 22, 2025 04:25
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (8e64d00) to head (3cb1ec9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6357   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         552      552           
  Lines       41937    41937           
  Branches     6356     6356           
=======================================
+ Hits        40407    40409    +2     
+ Misses       1490     1488    -2     
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@kt3k kt3k merged commit 1f4d0b2 into denoland:main Jan 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants