Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bytes,crypto,encoding,http,io,msgpack,streams,tar): make Uint8Array usages compatible with TS 5.7 #6372

Merged
merged 3 commits into from
Jan 31, 2025
Merged

refactor(bytes,crypto,encoding,http,io,msgpack,streams,tar): make Uint8Array usages compatible with TS 5.7 #6372

merged 3 commits into from
Jan 31, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 29, 2025

@kt3k kt3k requested a review from dsherret January 29, 2025 08:36
@kt3k kt3k requested a review from crowlKats as a code owner January 29, 2025 08:36
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.28%. Comparing base (f30741c) to head (3eca31f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
io/buffer.ts 62.50% 3 Missing ⚠️
streams/buffer.ts 62.50% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6372      +/-   ##
==========================================
- Coverage   96.31%   96.28%   -0.04%     
==========================================
  Files         553      554       +1     
  Lines       41973    42018      +45     
  Branches     6360     6367       +7     
==========================================
+ Hits        40426    40455      +29     
- Misses       1507     1523      +16     
  Partials       40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsherret dsherret mentioned this pull request Jan 30, 2025
Closed
dsherret
dsherret approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great idea with the Uint8Array_ type.

@kt3k kt3k changed the title refactor(crypto,encoding,http,io,streams,tar): make Uint8Array usages compatible with TS 5.7 refactor(bytes,crypto,encoding,http,io,msgpack,streams,tar): make Uint8Array usages compatible with TS 5.7 Jan 31, 2025
@kt3k kt3k merged commit ace6a0e into denoland:main Jan 31, 2025
19 checks passed
@kt3k kt3k deleted the refactor-prepare-for-ts-57 branch January 31, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
bytes crypto encoding http io msgpack streams tar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @dsherret