Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs/unstable): add readLink and readLinkSync #6373

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

jbronder
Copy link
Contributor

This PR adds the readLink and readLinkSync APIs to @std/fs, which are functions intended to mirror Deno.readLink and Deno.readLinkSync, respectively.

Towards #6255.

@jbronder jbronder requested a review from kt3k as a code owner January 31, 2025 00:35
@github-actions github-actions bot added the fs label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 96.25%. Comparing base (61ee836) to head (4e26303).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_read_link.ts 51.72% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6373      +/-   ##
==========================================
- Coverage   96.29%   96.25%   -0.04%     
==========================================
  Files         554      555       +1     
  Lines       42002    42031      +29     
  Branches     6365     6367       +2     
==========================================
+ Hits        40445    40459      +14     
- Misses       1517     1532      +15     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit d499310 into denoland:main Jan 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants