BREAKING(cli/unstable): rename ProgressBar end() method to stop()
#6406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6406 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 560 560
Lines 42350 42350
Branches 6383 6383
=======================================
Hits 40690 40690
Misses 1621 1621
Partials 39 39 ☔ View full report in Codecov by Sentry. |
timreichen
changed the title
ProgressBar end() method to stop()ProgressBar end() method to stop()
timreichen
changed the title
ProgressBar end() method to stop()ProgressBar end() method to stop()
|
@BlackAsLight What do you think? |
kt3k
changed the title
ProgressBar end() method to stop()ProgressBar end() method to stop()
|
I don't mind the name change |
|
I think you forgot to merge this pull request? |
|
I'd prefer to keep this and other breaking changes to ProgressBar open for a while to see if there's further feedbacks, and also to not break the usages for every release (ideally I like to merge all breaking changes to ProgressBar at once to minimize the impact of breakage) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
ProgressBarend()method tostop()to align with Spinner.