Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cbor): add support for bignums #6458

Merged
merged 7 commits into from
Mar 10, 2025
Merged

Conversation

BlackAsLight
Copy link
Contributor

Closes: #6455

This pull request adds native support for encoding bigints that requires +64 bits to encode via the tag item 2 and 3. It also adds automatic decoding of tag items 2 and 3 for converting them back into bigints instead of returning the CborTag instance.

@BlackAsLight BlackAsLight requested a review from kt3k as a code owner March 3, 2025 04:32
@github-actions github-actions bot added the cbor label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (1dee498) to head (58c575e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6458      +/-   ##
==========================================
- Coverage   95.68%   95.68%   -0.01%     
==========================================
  Files         576      576              
  Lines       43053    43088      +35     
  Branches     6450     6461      +11     
==========================================
+ Hits        41194    41227      +33     
- Misses       1820     1822       +2     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented Mar 7, 2025

Mostly looks good. Left one question

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 32f55fd into denoland:main Mar 10, 2025
18 checks passed
@BlackAsLight BlackAsLight deleted the cbor_bignum branch March 10, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impement Bignums for cbor
2 participants