-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cbor): add support for bignums #6458
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6458 +/- ##
==========================================
- Coverage 95.68% 95.68% -0.01%
==========================================
Files 576 576
Lines 43053 43088 +35
Branches 6450 6461 +11
==========================================
+ Hits 41194 41227 +33
- Misses 1820 1822 +2
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mostly looks good. Left one question |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #6455
This pull request adds native support for encoding bigints that requires +64 bits to encode via the tag item 2 and 3. It also adds automatic decoding of tag items 2 and 3 for converting them back into bigints instead of returning the
CborTag
instance.