feat(dotenv): add URL as envPath type #6621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6621 +/- ##
==========================================
- Coverage 94.54% 94.53% -0.01%
==========================================
Files 580 580
Lines 43887 43887
Branches 6501 6501
==========================================
- Hits 41492 41490 -2
- Misses 2352 2354 +2
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kt3k
reviewed
Apr 24, 2025
dotenv/mod_test.ts
Outdated
| @@ -29,6 +29,18 @@ Deno.test("load() handles non-existent .env files", async () => { | |||
| assertEquals({}, loadSync(loadOptions)); | |||
| }); | |||
|
|
|||
| Deno.test("load() handles URL as path for .env files", async () => { | |||
| const conf = loadSync({ | |||
| envPath: new URL(path.join(testdataDir, ".env"), import.meta.url), | |||
There was a problem hiding this comment.
new URL(path.join(testdataDir, ".env"), import.meta.url)
This doesn't work on windows as the paths are \ separated on windows, but that doesn't work as URL string
You need to call toFileUrl from @std/path
There was a problem hiding this comment.
Do you mean like this:
new URL(
toFileUrl(path.join(testdataDir, ".env")),
import.meta.url,
)?
kt3k
changed the title
|
Anything missing @kt3k for this to be merged? |
kt3k
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6620, by adding
URLas a valid type to theenvPathparameter in theLoadOptionsinterface.