fix(node/events): align EventEmitter#addListener with native node tests #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Jun 21, 2021
| ): this { | ||
| return this._addListener(eventName, listener, false); | ||
| // The body of this method is empty because it will be overwritten by later code. (`EventEmitter.prototype.addListener = EventEmitter.prototype.on;`) | ||
| // The purpose of this dirty hack is to get around the current limitation of TypeScript type checking. |
kt3k
reviewed
Jun 21, 2021
| const listeners_new_listener_emitted = []; | ||
|
|
||
| // Sanity check | ||
| assert.strictEqual(ee.addListener, ee.on); |
kt3k
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #911
Changes
test-event-emitter-add-listeners.jsnewListenerevent is now emitted with an unwrapped listenerEventEmitter#addListenernow points to the same function asEventEmitter#on