Reland "fix: move extended language formatting to client" (#1261) #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
commented
Feb 26, 2025
|
|
||
| const SUPPORTED_EXTENSIONS_BY_LANGUAGE_ID = new Map([ | ||
| ["jsonc", "jsonc"], | ||
| ["markdown", "md"], |
There was a problem hiding this comment.
This was ["markdown", "markdown"] in the first PR, causing the command to use --ext markdown which errored.
nayeemrmn
commented
Feb 26, 2025
Comment on lines
+71
to
+77
| if (status != 0) { | ||
| throw new Error(`Formatting failed: ${stderr}`); | ||
| } | ||
| // Never empty a file. | ||
| if (stdout.length == 0) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
The first PR didn't have this status check, only checked for spawn errors.
dsherret
requested changes
Feb 26, 2025
|
Superseded by denoland/deno#28310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1258, #1261.