-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autocomplete supports adding extensions #156
Conversation
return; | ||
} | ||
|
||
const denoSupportedExtensions = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we cannot know the actual module from import { foo } from "./bar"
So we can only guess based on commonly used extensions until they match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @axetroy - this is a very nice addition. I tested it locally and it works exactly as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @axetroy!
close #138
Typescript does not add extensions by default for cached modules when import from autocomplete
Now it has been fixed
/cc @ry @bartlomieju
before
after