-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to move import enhancement to server for better performance #181
Try to move import enhancement to server for better performance #181
Conversation
update from upstream
update from upstream
)" This reverts commit dd25cff. Don't need these now, will move to server
1. change snippets 2. change module name completion behavior
@lucacasonato Please review this |
From my initial testing the |
The std default to not need a version, should I just remove the trailing / ? |
I think it should default to using versioned imports, and if you give the @, people are more likely to actually set a version explicitly. |
I don't want to give the @ after the module name, because what if you already have a @ will result double @ And if you don't set fixed version, every time you trigger completion, it will send an HTTP GET request to fetch the latest version |
Thanks. @axetroy do you have any review comments? |
43861bd
to
4497a18
Compare
@axetroy Any others need to change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to move import enhancement(#172) to the server for better performance
SHOWCASE