-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support codeLens.testEnvs #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's reasonable solution, @crowlKats thoughts?
Yea, think so too. Will test it to see if it works properly |
@crowlKats any update? |
README.md
Outdated
@@ -149,6 +149,7 @@ extension has the following configuration options: | |||
- `deno.codeLens.testArgs`: Provides additional arguments that should be set | |||
when invoking the Deno CLI test from a code lens. _array of strings, default | |||
`[ "--allow-all" ]`_. | |||
- `deno.codeLens.testEnvs`: Provides additional process environments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs should be updated to provide more information about its purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've provided more information about its purpose.
docs/testing.md
Outdated
1. `deno.codeLens.testArgs`. They default to `[ "--allow-all" ]`. | ||
2. `deno.codeLens.testEnvs`. This envs will be passed to cli as process enviroments. | ||
|
||
## deno.unstable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## deno.unstable | |
## `deno.unstable` | |
@bartlomieju apologies; I tried however no luck getting it to work |
Okay, I'll investigate it myself after NYE |
e161934
to
f6fbbe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get it to work either, putting variables in deno.codeLens.testEnvs
has no effect on me. @ahuigo how were you able to make it work?
My test code
Reproduce my test0. Start this dev Deno plugin.Press 1. Set
|
@ahuigo when I do the same steps I get following output: One difference is that I don't see anything in "Debug console" or "Terminal" tabs. To be honest I'm a bit at loss why that happens. Everything looks correct in the PR. |
What's weird to me is that in breakpoint debugging, I can't read the value of
|
I think something is wrong with my setup - I can't hit any debug breakpoints I set in the client code :/ I'm looking into it |
Try turning off the Deno plugin. @bartlomieju |
I tried that, including removing Deno extension completely and it doesn't really help. No breakpoints are ever hit for the "test" command. |
I don't know if it has anything to do with this problem: #708 |
|
For #661
This new new option
codeLens.testEnvs
is used to custom environment variables for deno test